Skip to content

Release 6_0_0 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Release 6_0_0 #419

wants to merge 24 commits into from

Conversation

omnom62
Copy link
Contributor

@omnom62 omnom62 commented May 21, 2025

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):
    Preparing the code in main branch for Ansible Galaxy release submission

Related Task(s)

Related PR(s)

Component(s) name

galaxy.yaml
changelog.yaml
CHANGELOG.rst

Proposed changes

How to test

Test results

  • Sanity tests passed
  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4.2
  • 1.5-stream-2025-Q1

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

@gaige
Copy link
Contributor

gaige commented May 22, 2025

Can you update the PR information to be accurate for the testing versions and content?

@gaige
Copy link
Contributor

gaige commented May 22, 2025

Please add updates to the README.md:

  • Update the test versions to indicate we're testing against the versions we're testing against
  • Update Collection has been tested against 2.16+
  • Update the roadmap to remove "Planned" from 6.0.0 and change "Prospective" to "Planned" for 7.0.0
  • Should we point News and Announcements somewhere else other than the forum? There have been only two posts there in the last year (and a big gap before then) and not much technical?

@omnom62 omnom62 requested review from dmbaturin, gaige and andamasov May 22, 2025 20:08
@omnom62 omnom62 marked this pull request as ready for review May 24, 2025 06:31
@omnom62 omnom62 requested a review from a team as a code owner May 24, 2025 06:31
@RubenNL
Copy link
Contributor

RubenNL commented May 28, 2025

If possible, could this small PR be added to 6.0.0? #420

@andamasov andamasov requested a review from Copilot May 28, 2025 14:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the main branch for the Ansible Galaxy release submission by updating release documentation and cleaning up changelog fragments. Key changes include:

  • Removal of numerous outdated changelog fragment files.
  • Updates to the main changelog (CHANGELOG.rst) and README to reflect the new 6.0.0 release.
  • Adjustments to support documentation for VyOS versions 1.3+ and planned changes for upcoming versions.

Reviewed Changes

Copilot reviewed 103 out of 103 changed files in this pull request and generated 2 comments.

File Description
changelogs/fragments/*.yml (multiple files) Removed obsolete changelog fragments to streamline release notes.
changelogs/changelog.yaml Updated release notes and fragment references for the new release.
CHANGELOG.rst Added a new section for v6.0.0 with updated release summary and details.
README.md Updated testing version information and release table details.
Comments suppressed due to low confidence (1)

CHANGELOG.rst:14

  • [nitpick] There is an extra space between 'have' and 'breaking'. Please remove the double space to improve readability.
Although efforts have been made to maintain compatibility with the existing vyos collection modules, there have  breaking changes where

Copy link
Contributor

@gaige gaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot in here. In the future, we should put just the changelog changes in the release commit.
With that said, I'm not too concerned about the documentation changes, but it looks like there are a couple of test changes that might be related to the forward-looking work for the new release. If so, can we move those out onto another branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about tangible changes to test or code coming in the release PR. Can we pull these out separately? These look like they may be related to the API changes for the future release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants